Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MVC 미션 1단계] 베베(최원용) 미션 제출합니다. #356

Merged
merged 12 commits into from
Sep 15, 2023
Merged

[MVC 미션 1단계] 베베(최원용) 미션 제출합니다. #356

merged 12 commits into from
Sep 15, 2023

Conversation

wonyongChoi05
Copy link
Member

안녕하세요 엔델~! 이번 미션에서 리플렉션을 처음 써봤는데 코드가 좀 더럽네요 죄송합니다ㅠ 잘부탁드려요!

SproutMJ
SproutMJ requested changes Sep 14, 2023
View reviewed changes
Copy link

@SproutMJ SproutMJ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

안녕하세요 베베 코드 잘 구현해주셔서 리뷰할 부분이 엄청 적었던 것 같아요.
간단히 고쳐주시거나 의견 남겨주시면 좋을 것 같습니다.

study/src/test/java/reflection/ReflectionTest.java Show resolved Hide resolved
mvc/src/test/java/samples/TestController.java Show resolved Hide resolved
mvc/src/main/java/webmvc/org/springframework/web/servlet/mvc/tobe/AnnotationHandlerMapping.java Outdated Show resolved Hide resolved
mvc/src/main/java/webmvc/org/springframework/web/servlet/mvc/tobe/AnnotationHandlerMapping.java Show resolved Hide resolved
mvc/src/main/java/webmvc/org/springframework/web/servlet/mvc/tobe/AnnotationHandlerMapping.java Show resolved Hide resolved
SproutMJ
SproutMJ approved these changes Sep 15, 2023
View reviewed changes
Copy link

@SproutMJ SproutMJ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

파라미터에 final이 안붙어있지만 시간관계상 다음 스텝에 넘어가서 해주셔도 좋을 것 같습니다.
감사합니다.😀

@SproutMJ SproutMJ merged commit 75248ab into woowacourse:wonyongchoi05 Sep 15, 2023
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SproutMJ SproutMJ SproutMJ approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@wonyongChoi05 @SproutMJ @kang-hyungu